Re: [microblaze-uclinux] [patch] errno corruption

[David McCullough <davidm@xxxxxxxxxxxx>]

Jivin John Williams lays it down ...
> Hi Yashi,
> 
> Yasushi SHOJI wrote:
> 
> >it's nothing technical, I just don't know how to make it readable
> >
> >IMHO, it's more readable this way

I agree with Yashi here.  I like my assembly to be assembly so I can see
exactly what it is doing :-)

> >could you enlighten me on this?
> 
> It is just a matter of style.  Style is something that two people will 
> rarely agree about, and three or more will never agree! :)
> 
> Inline assembly is cryptic enough as it is, most of us look at it and 
> our eyes glaze over.  At least with the macros, you can look and easily 
> see "ok, here's where it puts the syscall args, here's where it puts the 
> syscall number, and so on"...  The raw register names make it that 
> little bit more difficult.

I agree with this to,  perhaps comments stating what each line is doing
would be better ?

Of course I don't even work on MB so my opinion is just that :-) :-)

Cheers,
Davidm

-- 
David McCullough, davidm@snapgear.com  Ph:+61 7 34352815 http://www.SnapGear.com
Custom Embedded Solutions + Security   Fx:+61 7 38913630 http://www.uCdot.org
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@itee.uq.edu.au
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/