[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [microblaze-uclinux] [dist] why vendors/Xilinx instead of vendors/config/microblaze?



At Fri, 17 Sep 2004 22:24:56 +0900,
yashi wrote:
> 
> At Fri, 17 Sep 2004 16:47:41 +1000,
> John Williams wrote:
> [...]
> > > anyone object?
> > 
> > Not at all, although as always backwards compatability is important, 
> > especially so that folks who've created their own local /vendors/... 
> > subdir (rather than tweaking mbvanilla) can continue without too much pain.
> > 
> > Perhaps just duplicate what's currently /vendors/Xilinx into 
> > /vendors/config/microblaze, update the mbvanilla_net, suzaku and that 
> > V2Pro platform, but still leave the old /Xilinx stuff there to whither 
> > and die?
> 
> ok, I'll create a patch to do that.  I'll also update README in
> vendors/Xilinx to make sure that people know the directory is
> obsoluted by vendors/config/microblaze.
> 
> I say we'll keep one or two dist cut and remove vendors/Xilinx all
> together.
> 
> I'll post a patch later.

Ok, here is the two patch to do the above.

first patch "move-common-config.arch-to-vendor-config-microblaze.diff"
just create new config.arch in vendors/config/microblaze/. this patch
shouldn't affects any products.

I have made a little modification to new config.arch.
 - remove trailing white space
 - rename LDLIBS-static to LDLIBS_static; follow others
   (this doesn't seems to be used by microblaze product anyway)
 - put -Wall in CFLAGS
 - remove XILINX_COMMON; this shouldn't be here, IMHO.

second patch "use-new-config.arch.diff" is preliminary. this change
microblaze products to use new config dir.  the reason why this patch
is preliminary is that the patch break all product using
XILINX_COMMON.  because new config.arch doesn't have it.

I'd put XILINX_COMMON in Makefile because XILINX_COMMON is only used
in the Makefile, or it can be moved to vendors/Insight/*/config.arch.

How do you want it, John?

best,
--
             yashi


Attachment: move-common-config.arch-to-vendor-config-microblaze.diff
Description: Binary data

Attachment: use-new-config.arch.diff
Description: Binary data