Re: [microblaze-uclinux] DCACHE always disabled, ICACHE always enabled

[John Williams <jwilliams@xxxxxxxxxxxxxx>]

Hi Steve,

Steve Sanders wrote:
> While stepping through some startup code trying to get my kernel
> working (still not there yet), I noticed that icache was getting
> enabled.  But... I have my configuration set up to DISable icache. 
> Digging in, it looks like icache will always be enabled and dcache will
> always be disabled.  I've made the following changes locally.  The
> first fixes the icache config, the second the dcache:
> 
> RCS file: /var/cvs/uClinux-2.4.x/arch/microblaze/kernel/mbvanilla.c,v
> retrieving revision 1.12
> diff -r1.12 mbvanilla.c
> 199c204
> <       #ifdef CONFIG_XILINX_MICROBLAZE0_USE_ICACHE
> ---
> 
>>#if CONFIG_XILINX_MICROBLAZE0_USE_ICACHE==1

Great, thanks for finding that.  The error was also present in 
platforms/uclinux-auto/machine.c and platforms/suzaku/machine.c - I've 
fixed all of them in CVS.

> Index: cache.h
> ===================================================================
> RCS file: /var/cvs/uClinux-2.4.x/include/asm-microblaze/cache.h,v
> retrieving revision 1.5
> diff -r1.5 cache.h
> 76c76
> < #ifdef CONFIG_XILINX_MICROBLAZE0_USER_DCACHE
> ---
> 
>>#ifdef CONFIG_XILINX_MICROBLAZE0_USE_DCACHE

This change was already in CVS, I think I fixed it a couple of weeks 
ago.  Try a CVS update, make sure I've got everything consistent.

> John... is this the "right" way to submit a proposal for a patch?

Normally it's better to pass the -u parameter to diff - for universal 
format.  It results in easier to read patch files.  This one was small, 
so I could apply it easily by hand.

When using CVS it's almost always a good idea to have the following 
contents of your ~/.cvsrc file:

[jwilliam@g435-9029 clean]$ cat ~/.cvsrc
-z3
update -PAd
rdiff -u
diff -ubBwpN
checkout -P

Cheers,


John
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@itee.uq.edu.au
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/