Re: [microblaze-uclinux] Source of kernel boot message, "MBVanillaflash probe..."?

[John Williams <jwilliams@xxxxxxxxxxxxxx>]

Hi David,

David Banas wrote:

> I didn't find a "mbvanilla.c" in that directory, but I did find a
> "mbvanilla-flash.c", which looks to be the culprit; is that the file you
> meant?

Yep, that's the one.

> Why does the code in that file "hard-wire" the FLASH base address and bus
> width, a la:
> 
> --------- code excerpt begins here. --------
> #ifdef CONFIG_MBVANILLA
> #define FLASH_BASE      0xff000000
> #define BUS_WIDTH       4
> #elif defined(CONFIG_UCLINUX_AUTO)
> #define FLASH_BASE      0xff000000
> #define BUS_WIDTH       4
> #endif
> --------- code excerpt ends here. --------
> 
> instead of using a constant from the new "auto-config" flow?

Basically I had to ensure I didn't break any old (ie mbvanilla) targets. 
  You should see in that same directory a file ml401_flash.c (or 
similar).  It uses the auto-config parameters as you would expect.

Because of this, I haven't done a clean integration of autoconfig on the 
flash/MTD mappings yet.  I guess we could put 
CONFIG_XILINX_FLASH_MEM_BASEADDR etc in there, then add mbvanilla 
back-compatability support into include/asm-microblaze/autoconfig.h. 
However, it's not really mbvanilla anymore - it should really go into a 
generic microblaze-auto.c or similar.

Sugguestions for a clean approach welcome :)

John
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@itee.uq.edu.au
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/