RE: [microblaze-uclinux] kernel compilation error: 'vmlist_lock undeclared'

["David Banas" <dbanas@xxxxxxxxxxxxxx>]

Thanks, John!

As part of preparing an "official" release for submission to your Web site,
I've attempted to chose the appropriate tag for users to specify when
checking out both kernel and dist. sources from the archive, the intent
being to know for certain that the patches I supply as part of that release
will apply cleanly to the particular version of the source that I recommend
and that the resultant code will compile.

I settled on "uClinux-2_4_29-uc0" for the kernel source, only because the
date associated with the more recent tag,
"before-snapgear-code-sync-20050504", (May 4, 2005) appeared to be
coincident with some complaints regarding recently introduced kernel
instabilities, which I thought I recalled coming through the list.

However, now I've run into the second case where the version of source code
associated with the former tag is quite old, as compared with that of the
latter. And, as I've just noticed after applying the patch you recommend,
below, I still don't have a successful kernel compilation. So, perhaps
there're more places where these 2 versions are quite different?

Have I made a poor decision here? Is the
"before-snapgear-code-sync-20050504" version of the kernel code a "stable"
release, and is it the one I should recommend to users of my release?

Thanks,

David Banas
Field Applications Engineer
Nu Horizons Electronics Corp.
2070 Ringwood Avenue
San Jose, CA 95131
(408)434-0800 - office
(415)846-5837 - cell
http://www.nuhorizons.com
> -----Original Message-----
> From: owner-microblaze-uclinux@itee.uq.edu.au [mailto:owner-microblaze-
> uclinux@itee.uq.edu.au] On Behalf Of John Williams
> Sent: Thursday, May 26, 2005 9:23 PM
> To: microblaze-uclinux@itee.uq.edu.au
> Subject: Re: [microblaze-uclinux] kernel compilation error: 'vmlist_lock
> undeclared'
>
> Hi David,
>
> David Banas wrote:
> > Hi All,
> >
> > Has anyone bumped into this error when compiling the kernel? It's
> occurring
> > while make is operating in the './fs/proc' directory.
> >
> > kcore.c: In function `read_kcore':
> > kcore.c:362: `vmlist_lock' undeclared (first use in this function)
>
> You need to freshen your copy of linux-2.4.x/include/linux/vmalloc.h
> from CVS, or apply the following trivial patch:
>
> Regards,
>
> John
>
> Index: vmalloc.h
> ===================================================================
> RCS file: /var/cvs/uClinux-2.4.x/include/linux/vmalloc.h,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -b -B -w -p -r1.4 -r1.5
> --- vmalloc.h   27 Aug 2003 03:13:47 -0000      1.4
> +++ vmalloc.h   14 Feb 2005 06:32:51 -0000      1.5
> @@ -69,6 +69,12 @@ extern struct vm_struct * vmlist;
>
>   #else /* NO_MM */
>
> +/*
> + * vmlist_lock is a read-write spinlock that protects vmlist
> + * Used in mm/vmalloc.c (get_vm_area() and vfree()) and fs/proc/kcore.c.
> + */
> +extern rwlock_t vmlist_lock;
> +
>   extern void vfree(void * addr);
>   extern void *__vmalloc(unsigned long size, int gfp_mask, pgprot_t prot);
>   extern long vread(char *buf, char *addr, unsigned long count);
>
>
> ___________________________
> microblaze-uclinux mailing list
> microblaze-uclinux@itee.uq.edu.au
> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-
> uclinux/
>
>
> ________________________________________________________________________
> This email has been scanned for all viruses by the MessageLabs Email
> Security System. For more information on a proactive email security
> service working around the clock, around the globe, visit
> http://www.messagelabs.com
> ________________________________________________________________________


___________________________
microblaze-uclinux mailing list
microblaze-uclinux@itee.uq.edu.au
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/