[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [microblaze-uclinux] Xilinx Ethernet Adapter Patch



Hi Paul,

Paul Hartke wrote:

It attempts to do three things:
1) Limit the number of command line Ethernet MAC addresses to the number
actually configured in this kernel.

Looks ok

2) Enables setting/disabling Pomiscuous mode.

This is pretty noisy - every time ifconfig does anything to the interface, we get a kernel log message telling us about promiscuous mode. Did you take this bit straight from recent mvista sources? I wonder if it might be made a bit quiter - e.g. only notify on a change of state, rather than every time?

3) Disables the Ethernet MAC from inserting/overwriting the MAC source
address on outgoing frames.  As far as I can tell, this is the normal Linux
behavior so I believe this is an oversight from the original Montavista
code.  Required for Linux to act as an Ethernet bridge/switch/hub.

This seems fine (at least doesn't seem to break anything!).

Have a think about the promiscuous stuff, if you can make a it a little quieter that would be good.

The target hardware design has two EMACs directly connected without any
intervening PHYs.  I am working on the adapter changes required to ignore
the PHY and directly communicate with another MAC.  That's more involved so
wanted to separate out these more limited mods for the community to
evaluate.

Sounds tricky - wiring the MII interfaces together?

John
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/