Re: [microblaze-uclinux] MDM UART support

[j.pfefferl@xxxxxxxxx (Dr. Johann Pfefferl)]

Hello John,

yes you are right. It is not the best solution. But if you take a look
inside the function ulite_probe (file ./drivers/serial/uartlite.c) the
"id" number is simply used as an index into the "ports" array. Of course
it would be better to replace the static "ports" array by a dynamically
alocated linked list data structure.

For me it was only a quick and dirty hack to get the MDM uart running in
a system which also includes normal uartlite devices.

Regards,
  Hans

John Williams <jwilliams@xxxxxxxxxxxxxx> wrote:
> Hi Hans,
> 
> Dr. Johann Pfefferl wrote:
> > Hello,
> > 
> > in the macro XILINX_MDMUART_PLATFORM_INITIALISER the "id" field of the
> > data structure must be set to a different value. For example
> > 
> > .id = (n+6)
> 
> Hmm, I wonder if it wouldn't be better instead for the uartlite driver
> itself to keep track of IDs handed out, and just increment them itself.
>  Statically forcing a +N nmodifier is fragile, if anyone ever adds more
> uartlite placeholders in thew platform init code, it will break.
> 
> What do you think?
> 
> John
> ___________________________
> microblaze-uclinux mailing list
> microblaze-uclinux@xxxxxxxxxxxxxx
> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/

-- 
Dr. Johann Pfefferl   ------------   mailto j.pfefferl at eubus dot net
Eubus GmbH          http://www.eubus.net ++++ http://www.ebmhydraxc.com
Gollierstr. 70
D-80339 Muenchen
Phone: +49 (0)89 45 22 578-67     Fax: +49 (0)89 45 22 578-55
Registergericht Muenchen HRB 145 336, Ust-Id Nr. DE 225 783 933
Geschaeftsfuehrer: Volker Ulrich, Peter Sibities
==
 -o)   A computer program does what you tell it to do,
 /\\        not what you want it to do.               
_\_v-                                                 
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/