[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[microblaze-uclinux] Re: [PATCH 02/60] microblaze_v4: Makefiles for Microblaze cpu
- To: Adrian Bunk <bunk@xxxxxxxxxx>
- Subject: [microblaze-uclinux] Re: [PATCH 02/60] microblaze_v4: Makefiles for Microblaze cpu
- From: Michal Simek <monstr@xxxxxxxxx>
- Date: Thu, 26 Jun 2008 20:46:44 +0200
- Cc: monstr@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, arnd@xxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, stephen.neuendorffer@xxxxxxxxxx, John.Linn@xxxxxxxxxx, john.williams@xxxxxxxxxxxxx, matthew@xxxxxx, will.newton@xxxxxxxxx, drepper@xxxxxxxxxx, microblaze-uclinux@xxxxxxxxxxxxxx, grant.likely@xxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxx, vapier.adi@xxxxxxxxx, alan@xxxxxxxxxxxxxxxxxxx, hpa@xxxxxxxxx
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=seznam.cz; h=Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Smtpd:X-Seznam-User:X-QM-Mark; b=Cg5Ia570oqkw9s3S0u2iRnjl3SJhSkMPwVoDU0z36FyiAFhEc9eKsGWR1H7J4i5H4 +CiD1QAm/u0SoVYuz0YbQDRXwB7wkPx3KyY1Og/FE4WokOXBiQbZRK8m4hhY7GkHRcO AItMGSmsvjVIbeI1nvkd5c2R/XybFtqiJegAEI0=
- In-reply-to: <20080626143623.GC30954@xxxxxxxxxxxxxxxxxxxxx>
- References: <1214483429-32360-1-git-send-email-monstr@xxxxxxxxx> <1214483429-32360-2-git-send-email-monstr@xxxxxxxxx> <1214483429-32360-3-git-send-email-monstr@xxxxxxxxx> <20080626143623.GC30954@xxxxxxxxxxxxxxxxxxxxx>
- Reply-to: microblaze-uclinux@xxxxxxxxxxxxxx
- Sender: owner-microblaze-uclinux@xxxxxxxxxxxxxx
- User-agent: Thunderbird 2.0.0.14 (Windows/20080421)
Adrian Bunk napsal(a):
> On Thu, Jun 26, 2008 at 02:29:31PM +0200, monstr@xxxxxxxxx wrote:
>> ...
>> --- /dev/null
>> +++ b/arch/microblaze/Makefile
>> ...
>> +# Work out HW multipler support. This is icky.
>> +# 1. Spartan2 has no HW multiplers.
>> +# 2. MicroBlaze v3.x always uses them, except in Spartan 2
>> +# 3. All other FPGa/CPU ver combos, we can trust the CONFIG_ settings
>> +ifeq (,$(findstring spartan2,$(CONFIG_XILINX_MICROBLAZE0_FAMILY)))
>> + ifeq ($(CPU_MAJOR),3)
>> + CPUFLAGS-1 += -mno-xl-soft-mul
>> + else
>> + # USE_HW_MUL can be 0, 1, or 2, defining a heirarchy of HW Mul support.
>> + CPUFLAGS-$(subst 1,,$(CONFIG_XILINX_MICROBLAZE0_USE_HW_MUL)) += -mxl-multiply-high
>> + CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_HW_MUL) += -mno-xl-soft-mul
>> + endif
>> +endif
>> +CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_DIV) += -mno-xl-soft-div
>> +CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_BARREL) += -mxl-barrel-shift
>> +CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_PCMP) += -mxl-pattern-compare
>> +
>> +CPUFLAGS-1 += $(call cc-option,-mcpu=v$(CPU_VER))
>> +
>> +# The various CONFIG_XILINX cpu features options are integers 0/1/2...
>> +# rather than bools y/n
>> +CFLAGS += $(CPUFLAGS-1)
>> +CFLAGS += $(CPUFLAGS-2)
>> ...
>
> Why are the options not bools?
>
> cu
> Adrian
because CONFIG_XILINX_... are 0, 1 or 2 not only y, n.
M
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/